[ https://issues.apache.org/jira/browse/PHOENIX-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313449#comment-14313449 ]
Hudson commented on PHOENIX-688: -------------------------------- FAILURE: Integrated in Phoenix-master #585 (See [https://builds.apache.org/job/Phoenix-master/585/]) PHOENIX-688 Add to_time and to_timestamp built-in functions (jtaylor: rev 11a76b297fad46cd7f51019810ba4d1a7b51b418) * phoenix-core/src/main/java/org/apache/phoenix/schema/types/PTime.java * phoenix-core/src/main/java/org/apache/phoenix/parse/ToTimeParseNode.java * phoenix-core/src/main/java/org/apache/phoenix/parse/ToDateParseNode.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertValuesIT.java * phoenix-core/src/main/java/org/apache/phoenix/expression/function/ToTimestampFunction.java * phoenix-core/src/main/java/org/apache/phoenix/util/csv/CsvUpsertExecutor.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ToDateFunctionIT.java * phoenix-core/src/main/java/org/apache/phoenix/compile/StatementContext.java * phoenix-core/src/main/java/org/apache/phoenix/schema/types/PTimestamp.java * phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java * phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java * phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java * phoenix-core/src/test/java/org/apache/phoenix/expression/SortOrderExpressionTest.java * phoenix-core/src/test/java/org/apache/phoenix/util/DateUtilTest.java * phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDate.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/VariableLengthPKIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/TruncateFunctionIT.java * phoenix-core/src/main/java/org/apache/phoenix/parse/ToTimestampParseNode.java * phoenix-core/src/main/java/org/apache/phoenix/expression/function/ToDateFunction.java * phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java * phoenix-core/src/main/java/org/apache/phoenix/util/DateUtil.java * phoenix-core/src/main/java/org/apache/phoenix/expression/function/ToTimeFunction.java * phoenix-core/src/it/java/org/apache/phoenix/mapreduce/CsvBulkLoadToolIT.java > Add to_time and to_timestamp built-in functions > ----------------------------------------------- > > Key: PHOENIX-688 > URL: https://issues.apache.org/jira/browse/PHOENIX-688 > Project: Phoenix > Issue Type: Task > Affects Versions: 3.0-Release > Reporter: James Taylor > Assignee: James Taylor > Attachments: PHOENIX-688.patch, PHOENIX-688_v2.patch, > PHOENIX-688_v3.patch > > > We already have a to_date function implemented by ToDateFunction, so adding a > ToTimeFunction could be done by just deriving the class from ToDateFunction > and changing the getDataType() to be PDataType.TIME instead. > For a general overview on adding a new built-in function, see the phoenix > blog > [here](http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html) > The to_timestamp function would be similar as well, but in this case we'd > want to register a new ToTimestampParseNode (very similar to > ToDateParseNode), that uses the DateUtil.getTimestampParser(format) to create > the timestamp instance. This class would then be defined in the > ToTimestampFunction as the nodeClass attribute (which would cause it to be > used to construct a ToTimestampFunction at compile time). -- This message was sent by Atlassian JIRA (v6.3.4#6332)