[
https://issues.apache.org/jira/browse/PHOENIX-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla updated PHOENIX-1115:
---------------------------------------------
Attachment: PHOENIX-1115_v4.patch
Thanks for review [~jamestaylor]. Here is the patch addressing the comments.
bq. Not sure I understand why you've changed
ExecutableUpdateStatisticsStatement with an override for trace(Boolean). Is
that necessary?
It's not related to ExecutableUpdateStatisticsStatement. In the patch it's
coming like that.
{code}
@Override
public AlterIndexStatement alterIndex(NamedTableNode indexTableNode,
String dataTableName, boolean ifExists, PIndexState state) {
return new ExecutableAlterIndexStatement(indexTableNode,
dataTableName, ifExists, state);
}
@Override
public TraceStatement trace(boolean isTraceOn) {
return new ExecutableTraceStatement(isTraceOn);
}
{code}
bq. Perhaps in a follow up JIRA, you can enhance the syntax to allow the
sampling rate to be set?
Sure I will raise a JIRA to set sampling rate as well.
If this patch is ok, I will commit it.
> Provide a SQL command to turn tracing on/off
> --------------------------------------------
>
> Key: PHOENIX-1115
> URL: https://issues.apache.org/jira/browse/PHOENIX-1115
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1115.patch, PHOENIX-1115_v2.patch,
> PHOENIX-1115_v3.patch, PHOENIX-1115_v4.patch, Screen Shot 2014-11-21 at
> 3.41.41 PM.png, tracing_in_different_rdbms.pdf
>
>
> Provide a SQL command that turns tracing on and off. For example, Oracle has
> this:
> {code}
> ALTER SESSION SET sql_trace = true;
> ALTER SESSION SET sql_trace = false;
> {code}
> We might consider allowing the sampling rate to be set as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
