[ 
https://issues.apache.org/jira/browse/PHOENIX-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348299#comment-14348299
 ] 

Jeongdae Kim commented on PHOENIX-938:
--------------------------------------

Jesse Yates - I found something strange in your codes, that 
callExecutor.start() do not be called anywhere in PhoenixIndexRpcScheduler as 
below.
    @Override
    public void start() {
        delegate.start();
    }

i think callExecutor.start() must be called in PhoenixIndexRpcScheduler.start() 
as below to work fine as you intended.

  @Override
  public void start() {
    delegate.start();
    callExecutor.start(port);
  }

could you explain your intention or some codes that i might not be seen before, 
if your implement is intended?

> Use higher priority queue for index updates to prevent deadlock
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-938
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-938
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 4.1
>            Reporter: James Taylor
>            Assignee: Jesse Yates
>             Fix For: 5.0.0, 4.1
>
>         Attachments: PHOENIX-938-master-v3.patch, phoenix-938-4.0-v0.patch, 
> phoenix-938-4.0-v0.patch, phoenix-938-master-v0.patch, 
> phoenix-938-master-v1.patch, phoenix-938-master-v2.patch, 
> phoenix-938-master-v4.patch, phoenix-938-master-v5.patch
>
>
> With our current global secondary indexing solution, a batched Put of table 
> data causes a RS to do a batch Put to other RSs. This has the potential to 
> lead to a deadlock if all RS are overloaded and unable to process the pending 
> batched Put. To prevent this, we should use a higher priority queue to submit 
> these Puts so that they're always processed before other Puts. This will 
> prevent the potential for a deadlock under high load. Note that this will 
> likely require some HBase 0.98 code changes and would not be feasible to 
> implement for HBase 0.94.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to