Thanks for the feedback Eli. I will go ahead and commit to 4.3. On Thu, Mar 5, 2015 at 8:46 PM, Eli Levine <[email protected]> wrote:
> There was a long thread a few months ago on private@ on the semantics of > different types of branches in Phoenix and there seemed to be consensus (or > at least no disagreement) that point releases (e.g. 4.3.1 -> 4.3.2) should > only contain bug fixes with this exception: "Possibly minor features that > are strictly additive are OK." PHOENIX-1452 code is fairly localized and > can be turned off with a config, so it seems to fall under that exception. > > I'm +1 for checking this into 4.3. > > As a side note, it's awesome this change is behind a config. We should do > that more where it makes sense IMHO. Thanks for your work, Samarth! > > Eli > > > > On Thu, Mar 5, 2015 at 4:23 PM, Samarth Jain <[email protected]> > wrote: > > > Hello Phoenix devs, > > > > I am planning on checking in PHOENIX-1452 to our 4.3 branch so that it > can > > be part of our next 4.3.1 release. The feature doesn't break any backward > > compatibility and doesn't put any restrictions on which side of jar, > client > > or server, should be upgraded first. > > > > PHOENIX-1452 provides us a way of looking into various global phoenix > > client side metrics. It's a step towards providing more visibility into > > what phoenix is doing and how much it is doing. Additionally, one has the > > capability to toggle the metrics collection on/off via config - > > phoenix.query.metrics.enabled > > > > Please let me know if you have any concerns. If none, I will proceed with > > checking it in to 4.3. > > > > Thanks, > > Samarth > > >
