[
https://issues.apache.org/jira/browse/PHOENIX-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355382#comment-14355382
]
ASF GitHub Bot commented on PHOENIX-1715:
-----------------------------------------
GitHub user shuxiong opened a pull request:
https://github.com/apache/phoenix/pull/45
PHOENIX-1715 Implement Build-in Math function sign
1. Add Build-in Math Function Sign
2. Add a new Type, PNumericType, which is superclass of all numeric type,
such as PInteger, PFloat etc.
PNumericType has method getSign
2.1 All integer types, PInteger, PLong etc., will compute sign result by
checking the content bytes.
2.2 All float types, PFloat, PDouble etc, will construct objects and
compare with zero, for their complex content bytes.
I mistakenly close last pull request, sorry for that.
Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shuxiong/phoenix 4.3-shuxiong-gsoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit 32089c5db6745aa710f579dcdae32b5fd2f03d51
Author: yesx <yeshuxi...@gmail.com>
Date: 2015-03-09T18:13:39Z
PHOENIX-1715 Implement Build-in Math function sign
commit 21f7aafd10fc3b6052fe14859918f3649b6b6de2
Author: yesx <yeshuxi...@gmail.com>
Date: 2015-03-10T15:28:59Z
PHOENIX-1715 add PNumericType, being all Integer DataType superclass
commit 4abe9c225754f1993eccb45094042c9e79016db6
Author: yesx <yeshuxi...@gmail.com>
Date: 2015-03-10T18:05:10Z
PHOENIX-1715 add PNumericType, being all Float DataType superclass
commit 92c7a3a869e22baf24a5a615bde69fca80698e6d
Author: yesx <yeshuxi...@gmail.com>
Date: 2015-03-10T18:18:59Z
code refinement
----
> Implement Build-in math function Sign
> -------------------------------------
>
> Key: PHOENIX-1715
> URL: https://issues.apache.org/jira/browse/PHOENIX-1715
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Shuxiong Ye
> Assignee: Shuxiong Ye
>
> Take a look at the typical math functions that are implemented in relational
> database systems
> (http://www.postgresql.org/docs/current/static/functions-math.html) and
> implement the same for Phoenix in Java following this guide:
> http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
