Github user codymarcel commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/41#discussion_r26240525
  
    --- Diff: 
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedRunner.java
 ---
    @@ -0,0 +1,171 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + *   or more contributor license agreements.  See the NOTICE file
    + *   distributed with this work for additional information
    + *   regarding copyright ownership.  The ASF licenses this file
    + *   to you under the Apache License, Version 2.0 (the
    + *   "License"); you may not use this file except in compliance
    + *   with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing, software
    + *   distributed under the License is distributed on an "AS IS" BASIS,
    + *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    + *   See the License for the specific language governing permissions and
    + *   limitations under the License.
    + */
    +
    +package org.apache.phoenix.pherf.workload;
    +
    +import java.sql.Connection;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +import java.util.Calendar;
    +import java.util.Date;
    +
    +import org.apache.phoenix.pherf.PherfConstants.RunMode;
    +
    +import org.apache.phoenix.pherf.result.DataModelResult;
    +import org.apache.phoenix.pherf.result.ResultManager;
    +import org.apache.phoenix.pherf.result.RunTime;
    +import org.apache.phoenix.pherf.result.ThreadTime;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import org.apache.phoenix.pherf.configuration.Query;
    +import org.apache.phoenix.pherf.util.PhoenixUtil;
    +
    +class MultithreadedRunner implements Runnable {
    +   private static final Logger logger = LoggerFactory
    +                   .getLogger(MultithreadedRunner.class);
    +   private Thread t;
    +   private Query query;
    +   private ThreadTime threadTime;
    +   private PhoenixUtil pUtil = new PhoenixUtil();
    +   private String threadName;
    +   private DataModelResult dataModelResult;
    +   private long numberOfExecutions;
    +   private long executionDurationInMs;
    +   private static long lastResultWritten = System.currentTimeMillis() - 
1000;
    +    private final ResultManager resultManager;
    +
    +    /**
    +     * Multithreaded runner
    +     *
    +     * @param threadName
    +     * @param query
    +     * @param dataModelResult
    +     * @param threadTime
    +     * @param numberOfExecutions
    +     * @param executionDurationInMs
    +     */
    +    MultithreadedRunner(String threadName,
    +                        Query query,
    +                        DataModelResult dataModelResult,
    +                        ThreadTime threadTime,
    +                        long numberOfExecutions,
    +                        long executionDurationInMs) {
    +        this.query = query;
    +        this.threadName = threadName;
    +        this.threadTime = threadTime;
    +        this.dataModelResult = dataModelResult;
    +        this.numberOfExecutions = numberOfExecutions;
    +        this.executionDurationInMs = executionDurationInMs;
    +        this.resultManager = new ResultManager(dataModelResult.getName(), 
RunMode.PERFORMANCE);
    +    }
    +
    +   /**
    +    * Executes run for a minimum of number of execution or execution 
duration
    +    */
    +   public void run() {
    +           logger.info("\n\nThread Starting " + t.getName() + " ; " + 
query.getStatement() + " for "
    +                           + numberOfExecutions + "times\n\n");
    +           Long start = System.currentTimeMillis();
    +           for (long i = numberOfExecutions; (i > 0 && ((System
    +                           .currentTimeMillis() - start) < 
executionDurationInMs)); i--) {
    +                   try {
    +                synchronized (resultManager) {
    +                    timedQuery();
    +                    if ((System.currentTimeMillis() - lastResultWritten) > 
1000) {
    +//                                 
resultUtil.writeResultToFile(dataModelResult, dataModelResult.getName(), 
RunMode.PERFORMANCE);
    --- End diff --
    
    Removed. The write method takes care of it now. That was from old 
implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to