[
https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dumindu Buddhika updated PHOENIX-1705:
--------------------------------------
Attachment: PHOENIX-1705_implement_ARRAY_APPEND_built_in_function2.patch
New patch.
[[email protected]], [~jamestaylor] Thanks for the feedback.
{quote}
To add to what Samarth said, for (2), no need to even track isCastable. Just
throw an exception out of your constructor if you find that it is not castable.
{quote}
I have removed the isCastible variable and changed the code to directly attempt
coerceBytes.
{quote}
3) Add tests that would trigger the coercion code. For example - Adding integer
to a string of varchars.
4) Add tests that invoke array_append in UPSERT and UPSERT SELECT statements.
5) Tests that calls some in-built function on the element being added. For ex -
SELECT ARRAY_APPEND(INTEGERARRAY
{quote}
Added test cases for above scenarios. Also added test cases to use ARRAY_APPEND
in where clauses.
> implement ARRAY_APPEND built in function
> ----------------------------------------
>
> Key: PHOENIX-1705
> URL: https://issues.apache.org/jira/browse/PHOENIX-1705
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Dumindu Buddhika
> Assignee: Dumindu Buddhika
> Attachments:
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function1.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
