[
https://issues.apache.org/jira/browse/PHOENIX-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365536#comment-14365536
]
James Taylor commented on PHOENIX-1691:
---------------------------------------
Thanks, [~rajeshbabu]. Please review, [~samarthjain]. Here's one minor comment:
- On your new grammar rule, I'm not sure on the precedence of the |, so to be
safe I'd put parens around the entire ON part, like this:
{code}
// Parse a trace statement.
trace_node returns [TraceStatement ret]
- : TRACE (flag = ON| flag = OFF)
- {ret = factory.trace(Tracing.isTraceOn(flag.getText()));}
+ : TRACE ( ( flag=ON ( WITH SAMPLING s = sampling_rate)? ) | flag = OFF)
{code}
> Allow settting sampling rate while enabling tracing.
> ----------------------------------------------------
>
> Key: PHOENIX-1691
> URL: https://issues.apache.org/jira/browse/PHOENIX-1691
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 5.0.0, 4.4
>
> Attachments: PHOENIX-1691.patch, PHOENIX-1691_v2.patch
>
>
> Now we can dynamically enable/disable tracing from query. We should also be
> able to set sampling rate while enabling tracing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
