Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/48#discussion_r26724977
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PUnsignedLong.java 
---
    @@ -95,6 +95,11 @@ public Object toObject(byte[] b, int o, int l, PDataType 
actualType, SortOrder s
       }
     
       @Override
    +    public boolean isCastableTo(PDataType targetType) {
    --- End diff --
    
    Was thinking to only make this change so that an UNSIGNED_LONG is castable 
to a TIMESTAMP. Allowing an INTEGER to be cast to a TIMESTAMP seems weird to 
me. How about we just start with this change for now and you adjust your tests 
accordingly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to