Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/46#discussion_r26819320
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/LikeExpression.java ---
@@ -289,11 +289,16 @@ public boolean evaluate(Tuple tuple,
ImmutableBytesWritable ptr) {
return true;
}
- String value = (String) PVarchar.INSTANCE.toObject(ptr,
getStrExpression().getSortOrder());
- boolean matched = pattern.matcher(value).matches();
+ String value = null;
+ if (logger.isTraceEnabled()) {
+ value = (String) PVarchar.INSTANCE.toObject(ptr,
getStrExpression().getSortOrder());
+ }
+ PVarchar.INSTANCE.coerceBytes(ptr, PVarchar.INSTANCE,
getStrExpression().getSortOrder(),
--- End diff --
Minor, but add a local variables at the beginning for strExpression,
strSortOrder, strDataType, patternExpression, as they're repeated quote often.
Also, here, change to:
strDataType.coerceBytes(ptr, strDataType, strSortOrder);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
