[
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375469#comment-14375469
]
Alicia Ying Shu edited comment on PHOENIX-1580 at 3/23/15 6:18 PM:
-------------------------------------------------------------------
What are the backward compatible issues? I did not see backward compatible
issues for including ORDER BY and LIMIT in subSelects. It is just how
internally we handle them. Users will submit the same query and get the same
result back if there is any result or an error message, no matter whether the
error message is from parser or from compile phase.
Nevertheless, I made changes to the grammar. UNION ALL tests passed. However I
met an issue for existing tests that Parameter Count in ParameterMetaData is
not correct. It should be because we split LIMIT from the original select_node,
the context is no longer the same. I am debugging the failed existing tests
still. I attached a working-in-progress patch phoenix-1580-v1-wipe.patch here.
Please take a look of UNION ALL implementation and Parameter Count issue.
The main changes for UNION ALL:
1. Modified grammar not allowing ORDER BY and LIMIT in subselects.
2. Not change PhoenixStatement.java
3. Removed setPlans()
4. Add Join tests and LIMIT test in UnionAllIT.java
Thanks. [~jamestaylor], [~maryannxue]
was (Author: aliciashu):
What are the backward compatible issues? I did not see backward compatible
issues for including ORDER BY and LIMIT in subSelects. It is just how
internally we handle them. Users will submit the same query and get the same
results back, no matter whether the error message is from parser or from
compile phase.
Nevertheless, I made changes to the grammar. UNION ALL tests passed. However I
met an issues for existing tests that Parameter Count in ParameterMetaData is
not correct. It should be because we split LIMIT from the original select_node,
the context is no longer the same. I am debugging the failed tests still. I
attached a working-in-progress patch phoenix-1580-v1-wipe.patch here. Please
take a look of UNION ALL implementation and Parameter Count issue. Thanks.
[~jamestaylor], [~maryannxue]
> Support UNION ALL
> -----------------
>
> Key: PHOENIX-1580
> URL: https://issues.apache.org/jira/browse/PHOENIX-1580
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Attachments: phoenix-1580-v1-wipe.patch, phoenix-1580.patch,
> unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
