FYI added https://issues.apache.org/jira/browse/PHOENIX-1770

Mark

-----Original Message-----
From: Mark Tse [mailto:mark....@d2l.com] 
Sent: March-23-15 10:11 AM
To: dev@phoenix.apache.org
Subject: psql.py - subprocess.call vs subprocess.check_call

Hi there,

I'm assuming the purpose of psql.py is to call it via a terminal so that it can 
be incorporated into a script.

If my assumption is correct, is there a reason we do:
subprocess.call(java_cmd, shell=True)

instead of:
subprocess.check_call (java_cmd, shell=True)

Code in question: https://github.com/apache/phoenix/blob/master/bin/psql.py#L42

Thanks,
Mark

Reply via email to