[ 
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391241#comment-14391241
 ] 

James Taylor commented on PHOENIX-1580:
---------------------------------------

One more thing is you don't need this check to wrap the final ResultIterator by 
a SequenceResultIterator, because the sequence allocation would occur in each 
child select statement and not at this level:
{code}
+        if (context.getSequenceManager().getSequenceCount() > 0) {
+            scanner = new SequenceResultIterator(scanner, 
context.getSequenceManager());
+        }
{code}

[~ayingshu] - if you could fix the indenting issues, do this minor change, and 
make sure your patch is rebased to the latest, that would be helpful. Thanks.

> Support UNION ALL
> -----------------
>
>                 Key: PHOENIX-1580
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1580
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch, 
> Phoenix-1580-v2.patch, phoenix-1580-v1-wipe.patch, phoenix-1580.patch, 
> unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to