[
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395218#comment-14395218
]
James Taylor commented on PHOENIX-1580:
---------------------------------------
Here's the complete MergeSortTopNResultIterator fix:
{code}
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.phoenix.iterate;
import java.sql.SQLException;
import java.util.List;
import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
import org.apache.phoenix.expression.Expression;
import org.apache.phoenix.expression.OrderByExpression;
import org.apache.phoenix.schema.tuple.Tuple;
/**
*
* ResultIterator that does a merge sort on the list of iterators provided,
* returning the rows ordered by the OrderByExpression. The input
* iterators must be ordered by the OrderByExpression.
*
*
* @since 0.1
*/
public class MergeSortTopNResultIterator extends MergeSortResultIterator {
private final int limit;
private final boolean clientSideOnly;
private int count = 0;
private final List<OrderByExpression> orderByColumns;
private final ImmutableBytesWritable ptr1 = new ImmutableBytesWritable();
private final ImmutableBytesWritable ptr2 = new ImmutableBytesWritable();
public MergeSortTopNResultIterator(ResultIterators iterators, Integer limit,
List<OrderByExpression> orderByColumns, boolean clientSideOnly) {
super(iterators);
this.limit = limit == null ? -1 : limit;
this.orderByColumns = orderByColumns;
this.clientSideOnly = clientSideOnly;
}
public MergeSortTopNResultIterator(ResultIterators iterators, Integer
limit, List<OrderByExpression> orderByColumns) {
this(iterators, limit, orderByColumns, false);
}
@Override
protected int compare(Tuple t1, Tuple t2) {
for (int i = 0; i < orderByColumns.size(); i++) {
OrderByExpression order = orderByColumns.get(i);
Expression orderExpr = order.getExpression();
boolean isNull1 = !orderExpr.evaluate(t1, ptr1) || ptr1.getLength()
== 0;
boolean isNull2 = !orderExpr.evaluate(t2, ptr2) || ptr2.getLength()
== 0;
if (isNull1 && isNull2) {
continue;
} else if (isNull1) {
return order.isNullsLast() ? 1 : -1;
} else if (isNull2) {
return order.isNullsLast() ? -1 : 1;
}
int cmp = ptr1.compareTo(ptr2);
if (cmp == 0) {
continue;
}
return order.isAscending() ? cmp : -cmp;
}
return 0;
}
@Override
public Tuple peek() throws SQLException {
if (limit >= 0 && count >= limit) {
return null;
}
return super.peek();
}
@Override
public Tuple next() throws SQLException {
if (limit >= 0 && count++ >= limit) {
return null;
}
return super.next();
}
@Override
public void explain(List<String> planSteps) {
resultIterators.explain(planSteps);
if (!clientSideOnly) {
planSteps.add(" SERVER" + (limit == -1 ? "" : " TOP " + limit + "
ROW" + (limit == 1 ? "" : "S"))
+ " SORTED BY " + orderByColumns.toString());
}
planSteps.add("CLIENT MERGE SORT");
}
@Override
public String toString() {
return "MergeSortTopNResultIterator [limit=" + limit + ",
count="
+ count + ", orderByColumns=" + orderByColumns
+ ", ptr1="
+ ptr1 + ", ptr2=" + ptr2 + "]";
}
}
{code}
> Support UNION ALL
> -----------------
>
> Key: PHOENIX-1580
> URL: https://issues.apache.org/jira/browse/PHOENIX-1580
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch,
> Phoenix-1580-v2.patch, Phoenix-1580-v3.patch, Phoenix-1580-v4.patch,
> Phoenix-1580-v5.patch, Phoenix-1580-v6.patch, Phoenix-1580-v7.patch,
> Phoenix-1580-v8.patch, phoenix-1580-v1-wipe.patch, phoenix-1580.patch,
> unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
