[
https://issues.apache.org/jira/browse/PHOENIX-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492777#comment-14492777
]
Nick Dimiduk commented on PHOENIX-1678:
---------------------------------------
I don't do this explicitly. Having a look at manifest files in
phoenix-core/target/phoenix-core-4.4.0-SNAPSHOT.jar:META-INF/MANIFEST.MF and
phoenix-server/target/phoenix-server-4.4.0-SNAPSHOT.jar:META-INF/MANIFEST.MF,
it seems we do have the artifact version information available in the
{{Implementation-Version}} field. I'm not sure what wires this up, I think it's
done by maven automatically as I see the same in the hbase jars.
> Detect client server jar mismatch/incomatibility by looking at the jar
> version stored in the MANIFEST file
> ----------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1678
> URL: https://issues.apache.org/jira/browse/PHOENIX-1678
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Labels: Newbie
>
> Today, our way of detecting whether client and server jars are different is
> by comparing the static member variable values in MetadataProtocol.java. The
> check is hacky and could easily break once we start considering clusters
> upgraded to snapshot and "sunk" RC jars. The current mechanism is also prone
> to bugs when developers forget to change the member variable values even
> though they changed the underlying metadata.
> If the jar names could be written to a MANIFEST file, then we can have a
> mechanism of detecting whether client and server jars belong to different
> versions or if they are incompatible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
