[
https://issues.apache.org/jira/browse/PHOENIX-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493390#comment-14493390
]
Hudson commented on PHOENIX-1826:
---------------------------------
SUCCESS: Integrated in Phoenix-master #676 (See
[https://builds.apache.org/job/Phoenix-master/676/])
PHOENIX-1826 Implement TrackOrderPreservingExpressionCompiler as Expression
visitor instead of ParseNode visitor (jtaylor: rev
2f0b51cbe8db817471d87d2521508ba6e42174e9)
* phoenix-core/src/main/java/org/apache/phoenix/compile/OrderByCompiler.java
*
phoenix-core/src/it/java/org/apache/phoenix/end2end/SubqueryUsingSortMergeJoinIT.java
*
phoenix-core/src/main/java/org/apache/phoenix/compile/OrderPreservingTracker.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/GroupByCompiler.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/SubqueryIT.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByIT.java
* phoenix-core/src/test/java/org/apache/phoenix/compile/QueryOptimizerTest.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java
*
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexOptimizationIT.java
* phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java
*
phoenix-core/src/main/java/org/apache/phoenix/compile/TrackOrderPreservingExpressionCompiler.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/VariableLengthPKIT.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java
> Implement TrackOrderPreservingExpressionCompiler as Expression visitor
> instead of ParseNode visitor
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1826
> URL: https://issues.apache.org/jira/browse/PHOENIX-1826
> Project: Phoenix
> Issue Type: Task
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 5.0.0, 4.4.0
>
> Attachments: PHOENIX-1826-combined.patch, PHOENIX-1826.patch,
> PHOENIX-1826.patch
>
>
> We currently traverse the ORDER BY ParseNodes in
> TrackOrderPreservingExpressionCompiler to determine if the rows will be
> ordered in row key order. This complicates supporting ORDER BY expressions
> that are an ordinal position (PHOENIX-1749), since it's a fair bit of code to
> manufacture a ParseNode when wildcards are used in the select. We should
> consider writing this visitor as an Expression instead and then using ordinal
> position would be easy as we could index into the RowProjector to get an
> Expression. See ViewWhereExpressionVisitor in CreateTableCompiler for an
> example.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
