[
https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494341#comment-14494341
]
Dumindu Buddhika edited comment on PHOENIX-1705 at 4/14/15 4:28 PM:
--------------------------------------------------------------------
Updated patch.
New test case added.
{quote}I thought it was affecting one of the test cases here directly.{quote}
Sorry I misunderstood earlier. There are test cases which are directly affected
by the change to pad method. (Cases with array SortOrder is DESC and array type
is char are affected)
{quote}Oh ya, right. But may be we need not have that 'fill' itself as any way
the byte[] is already have '0' filled in it? What you say. Not a big deal
anyway.{quote}
Hm yeah. That seems not necessary. So I removed it .
was (Author: dumindux):
Updated patch.
New test case added.
{quote}I thought it was affecting one of the test cases here directly.{quote}
Sorry I misunderstood earlier. There are test cases which are directly affected
by the change to pad method. (Cases with array SortOrder DESC are affected)
{quote}Oh ya, right. But may be we need not have that 'fill' itself as any way
the byte[] is already have '0' filled in it? What you say. Not a big deal
anyway.{quote}
Hm yeah. That seems not necessary. So I removed it .
> implement ARRAY_APPEND built in function
> ----------------------------------------
>
> Key: PHOENIX-1705
> URL: https://issues.apache.org/jira/browse/PHOENIX-1705
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Dumindu Buddhika
> Assignee: Dumindu Buddhika
> Attachments:
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function1.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function10.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function11.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function12.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function13.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function14.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function2.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function3.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function4.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function5.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function6.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function7.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function8.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function9.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
