Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526475
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
}
@Override
+ public String toString() {
+ StringBuilder sb = new StringBuilder(TO_STRING_BEGIN);
+ boolean isFirst = true;
+ final Format defaultFormat = null;
+ for (Byte o : byteArr) {
+ if (isFirst) {
+ isFirst = false;
+ } else {
+ sb.append(TO_STRING_SEPARATOR);
+ }
+ sb.append(this.baseType.toStringLiteral(o,
defaultFormat));
--- End diff --
Also it looks like toStringLiteral() is taking Object. So is it possible to
just use the toString() method defined in the super class PhoenixArray. This
way you won't have to duplicate code for toString() method for every array type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
