[
https://issues.apache.org/jira/browse/PHOENIX-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505488#comment-14505488
]
Nick Dimiduk commented on PHOENIX-1873:
---------------------------------------
bq. Nick Dimiduk is working on getting a pre-check in in place that'll enforce
our settings at build and commit time which will prevent us from getting in
this situation in the first place.
Yes, that's true. For that change, I intend to integrate check style plugin
into our maven build for catching things like referenced local variables and so
on. Once that change is in, we should remove the IDE-specific stuff because
maven is the project build tool, not Eclipse.
> Fix compilation errors in Pherf
> -------------------------------
>
> Key: PHOENIX-1873
> URL: https://issues.apache.org/jira/browse/PHOENIX-1873
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Cody Marcel
> Attachments: PHOENIX-1873.patch, PHOENIX-1873_v2.patch
>
>
> Please fix the compilation errors in Pherf. FYI, the default settings for
> Eclipse can be found in dev/eclipse_prefs_phoenix.epf as described here:
> http://phoenix.apache.org/contributing.html#Code_conventions
> {code}
> The method writeXML() from the type ConfigurationParserTest is never used
> locally ConfigurationParserTest.java
> /pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
> The value of the field DataLoader.properties is not used DataLoader.java
> /pherf/src/main/java/org/apache/phoenix/pherf/loaddata line 61 Java Problem
> The value of the field DataLoaderTest.loader is not used
> DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> 34 Java Problem
> The value of the field DataLoaderTest.model is not used
> DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> 33 Java Problem
> The value of the field QueryExecutor.resultUtil is not used
> QueryExecutor.java
> /pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java Problem
> The value of the field Result.type is not used Result.java
> /pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java Problem
> Type String[] of the last argument to method printRecord(Object...) doesn't
> exactly match the vararg parameter type. Cast to Object[] to confirm the
> non-varargs invocation, or pass individual arguments of type Object for a
> varargs invocation. CSVResultHandler.java
> /pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
> Java Problem
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
