[ 
https://issues.apache.org/jira/browse/PHOENIX-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506486#comment-14506486
 ] 

Samarth Jain commented on PHOENIX-900:
--------------------------------------

[~elilevine] - looks like the test you added is failing. Can you please check? 

https://builds.apache.org/job/Phoenix-master/703/console

Running org.apache.phoenix.execute.PartialCommitIT
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.799 sec <<< 
FAILURE! - in org.apache.phoenix.execute.PartialCommitIT
testDeleteFailure(org.apache.phoenix.execute.PartialCommitIT)  Time elapsed: 
0.015 sec  <<< FAILURE!
java.lang.AssertionError: Expected at least one statement in the list to fail
        at org.junit.Assert.fail(Assert.java:88)
        at 
org.apache.phoenix.execute.PartialCommitIT.testPartialCommit(PartialCommitIT.java:228)
        at 
org.apache.phoenix.execute.PartialCommitIT.testDeleteFailure(PartialCommitIT.java:177)


> Partial results for mutations
> -----------------------------
>
>                 Key: PHOENIX-900
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-900
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.4.0
>
>         Attachments: PHOENIX-900.patch
>
>
> HBase provides a way to retrieve partial results of a batch operation: 
> http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HTable.html#batch%28java.util.List,%20java.lang.Object[]%29
> Chatted with James about this offline:
> Yes, this could be included in the CommitException we throw 
> (MutationState:412). We already include the batches that have been 
> successfully committed to the HBase server in this exception. Would you be up 
> for adding this additional information? You'd want to surface this in a 
> Phoenix-y way in a method on CommitException, something like this: ResultSet 
> getPartialCommits(). You can easily create an in memory ResultSet using 
> MaterializedResultIterator plus the PhoenixResultSet constructor that accepts 
> this (just create a new empty PhoenixStatement with the PhoenixConnection for 
> the other arg).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to