[
https://issues.apache.org/jira/browse/PHOENIX-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509687#comment-14509687
]
James Taylor commented on PHOENIX-1728:
---------------------------------------
Looks great. Thanks for the revisions, [~cody.mar...@gmail.com]. Two minor
requests:
- In the top level pom, would you mind moving the phoenix-assembly module to be
listed last so that the other unit tests run before the tar building?
{code}
<modules>
<module>phoenix-core</module>
<module>phoenix-flume</module>
<module>phoenix-pig</module>
<module>phoenix-server-client</module>
<module>phoenix-server</module>
<module>phoenix-pherf</module>
<module>phoenix-spark</module>
<module>phoenix-assembly</module>
</modules>
{code}
- Can you squash your commits into a single commit and use the following as the
commit message (so that the Jenkins build results get linked here)?
PHOENIX-1728 Pherf - Make tests use mini cluster
Not sure if there's a flapper, but if I do a mvn clean followed by a mvn
package, I sometimes get this failure on my Mac (however, subsequent
invocations of mvn package work fine):
{code}
Failed tests:
ResultTest.testMonitorResult:100 Failed to get correct amount of CSV records.
expected:<252> but was:<261>
{code}
> Pherf - Make tests use mini cluster
> -----------------------------------
>
> Key: PHOENIX-1728
> URL: https://issues.apache.org/jira/browse/PHOENIX-1728
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Cody Marcel
> Assignee: Cody Marcel
> Priority: Minor
> Labels: newbie
> Fix For: 5.0.0, 4.4.0
>
>
> Some unit tests currently depend on a cluster being available or they will
> fail. Make these tests use mini cluster.
> Tests are currently disabled in the build. We need to enable these.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
