Excellent, Nick. For us non HBasers, what's the recommended workflow? Only check-in if our BuildBot passes?
On Thu, Apr 23, 2015 at 4:37 PM, Enis Söztutar <[email protected]> wrote: > Great work! You the man. > > Enis > > On Thu, Apr 23, 2015 at 4:35 PM, Mujtaba Chohan <[email protected]> wrote: > >> That's awesome Nick! >> >> On Thu, Apr 23, 2015 at 4:30 PM, Eli Levine <[email protected]> wrote: >> >> > Great work, Nick! Thanks for doing this. >> > >> > Eli >> > >> > On Thu, Apr 23, 2015 at 4:01 PM, Nick Dimiduk <[email protected]> >> wrote: >> > >> > > Devs -- >> > > >> > > We now have a pre-commit BuildBot [0]! Our pedantic build-checking >> robot >> > > servant passed its first judgement [1] this afternoon. It is a clone >> [2] >> > of >> > > the buildbot from HBase, so it's somber tone should be familiar to many >> > of >> > > you. Same rules apply -- attach your patch, hit "Submit Patch" and the >> > > tools will pick up from there. >> > > >> > > Our robot is about as intelligent as a young dog, it's pretty flexible >> in >> > > applying whatever kind of patch file you give it. It's also able to >> look >> > at >> > > the patch file name and decide which branch it should be run against. >> So >> > > far it's been trained to work with branches "3.0," "3.2," "4.0.1," >> "4.2," >> > > "4.3 4.x-HBase-0.98," and "master". Include any of those explicitly in >> > your >> > > patch name and it'll run on vs that branch. Master is the default. You >> > can >> > > train it for new branches by adding them to the properties file [3]. >> > > >> > > Let me know if you have any issues, or just open tickets and fix 'em >> > > yourselves ;) >> > > -n >> > > >> > > [0]: https://builds.apache.org/job/PreCommit-PHOENIX-Build/ >> > > [1]: >> > > >> > > >> > >> https://issues.apache.org/jira/browse/PHOENIX-1909?focusedCommentId=14509986&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14509986 >> > > [2]: >> > > >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blob;f=dev/test-patch.sh;h=1ed7e6224093aebae78f18869ff069153e0437ea;hb=HEAD >> > > [3]: >> > > >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blob;f=dev/test-patch.properties;h=6a82eeefa540687b73a54d36275067b61f4c8775;hb=HEAD#l30 >> > > >> > >>
