[ 
https://issues.apache.org/jira/browse/PHOENIX-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515091#comment-14515091
 ] 

Hadoop QA commented on PHOENIX-1882:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12728513/PHOENIX-1882-master-v2.patch
  against master branch at commit a9af6fe65f46c3830da33caf8d34b292258388eb.
  ATTACHMENT ID: 12728513

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 3 
warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/29//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/29//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/29//console

This message is automatically generated.

> Issue column family deletes instead of row deletes in PTableImpl
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-1882
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1882
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>             Fix For: 5.0.0, 4.4.0
>
>         Attachments: PHOENIX-1882-4.x-HBase-0.98-v2.patch, 
> PHOENIX-1882-4.x-HBase-0.98.patch, PHOENIX-1882-master-v2.patch, 
> PHOENIX-1882-master.patch
>
>
> Since PTable knows which column families are under control of Phoenix 
> (table.getColumnFamilies()), we should issue a column family delete for each 
> of them instead of a row delete (this is what it gets translated to anyway 
> when it gets to the server). This is actually better, as Phoenix should not 
> attempt to manage undeclared column families.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to