[ 
https://issues.apache.org/jira/browse/PHOENIX-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518766#comment-14518766
 ] 

James Taylor commented on PHOENIX-1856:
---------------------------------------

Thanks for the revision, [~ram_krish]. It turns out, we'll only need MIN_KEY. 
The end goal will be to use MIN_KEY in the primary key constraint instead of 
the REGION_NAME (which will become at regular Key Value column instead). Other 
minor nit: don't use ImmutableBytesPtr, but use ImmutableBytesWritable instead. 
You only should use ImmutabeBytesPtr if you're using it for a key in a Map, as 
it caches the hashcode. That won't be necessary in this case, so it's just 
extra overhead. You can use the ByteUtil.copyKeyBytesIfNecessary() method to 
copy the bytes only if necessary. Good catch on setting in when a split occurs 
too.

> Include min and max row key for each region in stats row
> --------------------------------------------------------
>
>                 Key: PHOENIX-1856
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1856
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 5.0.0, 4.4.0
>
>         Attachments: Phoenix-1856_1.patch, Phoenix-1856_2.patch
>
>
> It'd be useful to record the min and max row key for each region to make it 
> easier to filter guideposts through queries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to