[
https://issues.apache.org/jira/browse/PHOENIX-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519377#comment-14519377
]
ASF GitHub Bot commented on PHOENIX-1875:
-----------------------------------------
Github user dumindux commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/79#discussion_r29337479
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PArrayDataType.java
---
@@ -543,6 +544,156 @@ private static void writeEndBytes(byte[] array, int
newOffsetArrayPosition, int
Bytes.putByte(array, newOffsetArrayPosition + offsetArrayLength +
byteSize + 2 * Bytes.SIZEOF_INT, header);
}
+ public static boolean prependItemToArray(ImmutableBytesWritable ptr,
int length, int offset, byte[] arrayBytes, PDataType baseType, int arrayLength,
Integer maxLength, SortOrder sortOrder) {
+ int elementLength = maxLength == null ? ptr.getLength() :
maxLength;
+ if (ptr.getLength() == 0) {
+ elementLength = 0;
+ }
+
+ //padding
+ if (elementLength > ptr.getLength()) {
+ baseType.pad(ptr, elementLength, sortOrder);
+ }
+
+ int elementOffset = ptr.getOffset();
+ byte[] elementBytes = ptr.get();
+
+ byte[] newArray;
+ if (!baseType.isFixedWidth()) {
+ int offsetArrayPosition = Bytes.toInt(arrayBytes, offset +
length - Bytes.SIZEOF_INT - Bytes.SIZEOF_INT - Bytes.SIZEOF_BYTE,
Bytes.SIZEOF_INT);
+ int offsetArrayLength = length - offsetArrayPosition -
Bytes.SIZEOF_INT - Bytes.SIZEOF_INT - Bytes.SIZEOF_BYTE;
+ arrayLength = Math.abs(arrayLength);
+
+ //checks whether offset array consists of shorts or integers
+ boolean useInt = offsetArrayLength / arrayLength ==
Bytes.SIZEOF_INT;
+ boolean convertToInt = false;
+
+ int endElementPosition = getOffset(arrayBytes, arrayLength -
1, !useInt, offsetArrayPosition + offset) + elementLength + Bytes.SIZEOF_BYTE;
+
+ int newOffsetArrayPosition;
+ int offsetShift;
+ int firstNonNullElementPosition = 0;
+ int currentPosition = 0;
+ //handle the case where appended element is null
+ if (elementLength == 0) {
+ int nulls = 0;
+ //counts the number of nulls which are already at the
beginning of the array
+ for (int index = 0; index < arrayLength; index++) {
+ int currOffset = getOffset(arrayBytes, index, !useInt,
offsetArrayPosition + offset);
+ if (arrayBytes[offset + currOffset] ==
QueryConstants.SEPARATOR_BYTE) {
+ nulls++;
+ } else {
+ //gets the offset of the first element after nulls
at the beginning
+ firstNonNullElementPosition = currOffset;
+ break;
+ }
+ }
+ nulls++;
+
+ int nMultiplesOver255 = nulls / 255;
+ endElementPosition = getOffset(arrayBytes, arrayLength -
1, !useInt, offsetArrayPosition + offset) + nMultiplesOver255 + 2 *
Bytes.SIZEOF_BYTE;
--- End diff --
You mean without assigning it to a variable directly using it in
PArrayDataType.useShortForOffsetArray(maxOffset) method?
> implement ARRAY_PREPEND built in function
> -----------------------------------------
>
> Key: PHOENIX-1875
> URL: https://issues.apache.org/jira/browse/PHOENIX-1875
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Dumindu Buddhika
> Assignee: Dumindu Buddhika
>
> ARRAY_PREPEND(1, ARRAY[2, 3]) = ARRAY[1, 2, 3]
> ARRAY_PREPEND("a", ARRAY["b", "c"]) = ARRAY["a", "b", "c"]
> ARRAY_PREPEND(null, ARRAY["b", "c"]) = ARRAY[null, "b", "c"]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
