[
https://issues.apache.org/jira/browse/PHOENIX-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated PHOENIX-1948:
----------------------------------
Attachment: PHOENIX-1948.01.patch
Here's an updated patch that does some cleanup to make it more clear where each
jar is being searched. Assignment for each global variable is grouped together
in one place. This required moving some variable declarations earlier. I also
cleaned up the indentation of this section to that it matches the 4-space style
guide. For these reasons, maybe it's easier to review with a tool than simple
inspection of the diff.
Output of the script when run in various contexts:
>From git checkout:
{noformat}
phoenix_class_path:
hbase_conf_dir: .
hbase_conf_path: .
current_dir: /Users/ndimiduk/repos/phoenix/bin
phoenix_jar_path: /Users/ndimiduk/repos/phoenix/bin/../phoenix-assembly/target/*
phoenix_client_jar:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-assembly/target/phoenix-4.4.0-HBase-0.98-SNAPSHOT-client.jar
phoenix_test_jar_path:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-core/target/*
hadoop_common_jar_path:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-assembly/target/*
hadoop_common_jar:
hadoop_hdfs_jar_path:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-assembly/target/*
hadoop_hdfs_jar:
testjar:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-core/target/phoenix-core-4.4.0-HBase-0.98-SNAPSHOT-tests.jar
phoenix_queryserver_jar:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-server/target/phoenix-server-4.4.0-HBase-0.98-SNAPSHOT-runnable.jar
phoenix_thin_client_jar:
/Users/ndimiduk/repos/phoenix/bin/../phoenix-server-client/target/phoenix-4.4.0-HBase-0.98-SNAPSHOT-thin-client.jar
{noformat}
>From maven assembly package:
{noformat}
phoenix_class_path:
hbase_conf_dir: .
hbase_conf_path: .
current_dir: /private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin
phoenix_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../phoenix-assembly/target/*
phoenix_client_jar:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../phoenix-4.4.0-HBase-0.98-SNAPSHOT-client.jar
phoenix_test_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../phoenix-core/target/*
hadoop_common_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../phoenix-assembly/target/*
hadoop_common_jar:
hadoop_hdfs_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../phoenix-assembly/target/*
hadoop_hdfs_jar:
testjar:
phoenix_queryserver_jar:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../lib/phoenix-server-4.4.0-HBase-0.98-SNAPSHOT-runnable.jar
phoenix_thin_client_jar:
/private/tmp/phoenix-4.4.0-HBase-0.98-SNAPSHOT/bin/../phoenix-4.4.0-HBase-0.98-SNAPSHOT-thin-client.jar
{noformat}
>From make_rc.sh package:
{noformat}
phoenix_class_path:
hbase_conf_dir: .
hbase_conf_path: .
current_dir: /private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin
phoenix_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-assembly/target/*
phoenix_client_jar:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-4.4.0-HBase-0.98-client.jar
phoenix_test_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-core/target/*
hadoop_common_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-assembly/target/*
hadoop_common_jar:
hadoop_hdfs_jar_path:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-assembly/target/*
hadoop_hdfs_jar:
testjar:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-core-4.4.0-HBase-0.98-tests.jar
phoenix_queryserver_jar:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-server-4.4.0-HBase-0.98-runnable.jar
phoenix_thin_client_jar:
/private/tmp/phoenix-4.4.0-HBase-0.98-bin/bin/../phoenix-4.4.0-HBase-0.98-thin-client.jar
{noformat}
Notice some of the above paths are still incorrect; for instance there's
"target" paths produced when run from the make_rc.sh package. I think there's
more cleanup to be done here.
> bin scripts run under make_rc.sh packaging
> ------------------------------------------
>
> Key: PHOENIX-1948
> URL: https://issues.apache.org/jira/browse/PHOENIX-1948
> Project: Phoenix
> Issue Type: Bug
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0, 4.4.0
>
> Attachments: PHOENIX-1948.00.patch, PHOENIX-1948.01.patch
>
>
> Per recent discussion at the tail of PHOENIX-1904 and the [mailing list
> thread|http://mail-archives.apache.org/mod_mbox/phoenix-dev/201505.mbox/%3cCAFmqivpaWE8p7=w9ucemo8ma94qp7hy0ajez323uxu3zcgl...@mail.gmail.com%3e],
> bin scripts need to support packaging formats of both maven tarball and
> make_rc.sh tarballs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
