It's not the rat plugin, but my patch on PHOENIX-1962 is doing header
validation. Give it a spin with `mvn verify -DskipTests`.

On Fri, Apr 24, 2015 at 5:38 PM, James Taylor <jamestay...@apache.org>
wrote:

> +1
>
> On Fri, Apr 24, 2015 at 5:37 PM, Jesse Yates <jesse.k.ya...@gmail.com>
> wrote:
> > +1 totally.
> >
> > On Fri, Apr 24, 2015 at 5:36 PM Nick Dimiduk <ndimi...@gmail.com> wrote:
> >
> >> Hi folks,
> >>
> >> I've pushed a couple commits that clean up the ASL headers in our code.
> >> That means the pre-commit bot's "release audit warnings" section is now
> >> correct and talking about *your patch*. PMC are required to validate
> these
> >> headers on releases, but I see no reason for us to not verify this more
> >> often. To that effect, I propose we enable the rat check in the maven
> >> pre-compile phase. I believe dev/make_rc.sh already verifies pristine
> >> working directory at release time. We can make the filters a bit more
> >> lenient to allow for non-pristine working directory in developer
> sandboxes.
> >>
> >> Any opinions?
> >>
> >> -n
> >>
>

Reply via email to