[ 
https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548443#comment-14548443
 ] 

Dave Hacker commented on PHOENIX-1504:
--------------------------------------

I've made some progress on this but won't be able to spend more time on it.  

I've completed enough to have add column working from 4.5 moving forward, but 
upgrade and error handling from earlier client/server versions is not yet 
complete, minus some concurrency issues that need to be addressed and tested.  

Here is what works
 - Alter table add column will appropriately update the system.catalog table 
for the table and all of its child views if phoenix is deployed in a new 
environment

Here is what is left
 - Figure out a locking strategy that works and test it  ( I recommend locking 
the parent table anytime a view is altered, this has to be done before taking 
the lock on the view, which actually eliminates the need to lock the view)  The 
con here is it may be too coarse in the case of lots of views being altered at 
the same time.  
 - Determine if there are any view types that should not automatically have the 
column added
 - Upgrade path for old versions of phoenix to version 4.5 to populate 
base_column_count
 - Figure out what to do in the case of base_column_count not being equals to 
the column count of the parent table
 - Invalidate server side cache if necessary
 - Support remove column

> Allow schema changes to table with views
> ----------------------------------------
>
>                 Key: PHOENIX-1504
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1504
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>         Attachments: PHOENIX-1504-wip.patch
>
>
> We currently disallow any schema modifications to a table that has views. We 
> should relax that constraint and push the schema change as necessary out to 
> all views.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to