[
https://issues.apache.org/jira/browse/PHOENIX-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552569#comment-14552569
]
James Taylor commented on PHOENIX-1982:
---------------------------------------
Patch looks good. One minor nit you can fix on commit. In the limitation
section, express the first one as something you can't do (like you've done with
the others). For example, maybe something like "The jar containing the UDFs
must be manually added to HDFS". Also, it'd be good if you referenced Phoenix
JIRAs for each limitation.
{code}
+* adding new SQL statements for add/remove jars
{code}
On the functional side of things, I think we should make a few modifications:
- Declaring a default value is orthogonal to whether it's a constant or not, so
we should change this.
- Default, min, and max values should not require quotes around it. You should
be able to specify them as any other literal in a SQL statement (i.e. quoted if
it's a string, not quoted for numbers, date literals should be ok).
Would you mind filing JIRAs for those?
> Documentation for UDF support
> -----------------------------
>
> Key: PHOENIX-1982
> URL: https://issues.apache.org/jira/browse/PHOENIX-1982
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.4.0
>
> Attachments: PHOENIX-1982.patch, PHOENIX-1982_v2.patch,
> create_function.csv
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
