Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/81#issuecomment-104059599
Actually, change it to rhs.getDataType().isCoercibleTo(PVarChar.INSTANCE).
That's more or less as you've described, but done in a way that doesn't hard
code type checks. Our PDataType does not necessarily map 1:1 with SQL types, so
down the road we might add a PUTF16EncodedType which would still map to a
VARCHAR is SQL. This type of check makes a change like this more manageable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
