[
https://issues.apache.org/jira/browse/PHOENIX-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563927#comment-14563927
]
Jan Fernando commented on PHOENIX-1819:
---------------------------------------
[~samarthjain] This looks fantastic! Really great work.
As we discussed I think there are 2 small changes to help make it easier for
clients to consume the metrics:
1) Change:
{code}
public static Map<String, List<Pair<String, Long>>>
getReadMetricsForLastCommit(Connection conn)
->
public static Map<String, Map<String, Long>>
getReadMetricsForLastCommit(Connection conn)
{code}
and
{code}
public static Map<String, List<Pair<String, Long>>>
getMutationMetricsForLastCommit(Connection conn)
->
public static Map<String, Map<String, Long>>
getMutationMetricsForLastCommit(Connection conn)
{code}
in PhoenixRuntime to make it easier for clients to look up specific metrics by
name and make the API consistent with the ResultSet level metric methods.
2) Figure out how best to expose the metric names to clients so that they have
a stable way to look up metrics versus right now relying on the Enum.name().
> Report resource consumption per phoenix statement
> -------------------------------------------------
>
> Key: PHOENIX-1819
> URL: https://issues.apache.org/jira/browse/PHOENIX-1819
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Fix For: 5.0.0, 4.4.1
>
> Attachments: PHOENIX-1819-rebased.patch, PHOENIX-1819.patch
>
>
> In order to get insight into what phoenix is doing and how much it is doing
> per request, it would be ideal to get a single log line per phoenix request.
> The log line could contain request level metrics like:
> 1) Number of spool files created.
> 2) Number of parallel scans.
> 3) Number of serial scans.
> 4) Query failed - boolean
> 5) Query time out - boolean
> 6) Query time.
> 7) Mutation time.
> 8) Mutation size in bytes.
> 9) Number of mutations.
> 10) Bytes allocated by the memory manager.
> 11) Time spent by threads waiting for the memory to be allocated.
> 12) Number of tasks submitted to the pool.
> 13) Number of tasks rejected.
> 14) Time spent by tasks in the queue.
> 15) Time taken by tasks to complete - from construction to execution
> completion.
> 16) Time taken by tasks to execute.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
