[ https://issues.apache.org/jira/browse/PHOENIX-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Dimiduk reopened PHOENIX-1976: ----------------------------------- Reopening for the 1.1 branches (it's not on 4.x-HBase-1.1) and 4.4 branches. > Improve PhoenixDriver registration when addShutdownHook fails > ------------------------------------------------------------- > > Key: PHOENIX-1976 > URL: https://issues.apache.org/jira/browse/PHOENIX-1976 > Project: Phoenix > Issue Type: Bug > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Minor > Fix For: 5.0.0, 4.5.0 > > Attachments: PHOENIX-1976-master.patch > > > Noticed this in running some tests. RegionServer was shutting down and > MetaDataRegionObserver was just invoking {{postOpen}} > When the {{Class.forName(PhoenixDriver.class.getName())}} gets called, the > static initializer in {{PhoenixDriver}} gets invoked. Because the > RegionServer is already stopping, the {{addShutdownHook}} fails with an > {{IllegalArgumentException}}. > It's not a _huge_ concern because we know the JVM is going down, but there > are a few things we could handle better: > * Ensure the PhoenixDriver gets closed if the shutdown hook fails to register > * Avoid registering the PhoenixDriver instance if we're shutting down -- This message was sent by Atlassian JIRA (v6.3.4#6332)