[
https://issues.apache.org/jira/browse/PHOENIX-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582826#comment-14582826
]
James Taylor edited comment on PHOENIX-1987 at 6/12/15 2:06 AM:
----------------------------------------------------------------
Not 100% sure, but I think we should throw if NaN happens. For example, we
throw on an attempt to divide by zero. Would be good to confirm what other
databases do, like Postgres or mySQL.
Don't return false, though, as that should only be returned if you don't have
enough information to compute a value. In this case, you have all the
information you need, it's just that you can't compute a value.
was (Author: jamestaylor):
Not 100% sure, but I think we should throw if NaN happens. For example, we
throw on an attempt to divide by zero. Would be good to confirm what other
databases do, like Postgres or mySQL.
> SIGN built-in function should be order preserving
> -------------------------------------------------
>
> Key: PHOENIX-1987
> URL: https://issues.apache.org/jira/browse/PHOENIX-1987
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Shuxiong Ye
> Fix For: 5.0.0, 4.5.0, 4.4.1
>
> Attachments:
> 0001-PHOENIX-1987-SIGN-built-in-function-should-be-order_v2.patch,
> 0001-PHOENIX-1987-fixing-getKeyFormationTraversalIndex-in-SIGN-function.patch
>
>
> The SIGN built-in function preserves the order of its input. This needs to be
> explicitly implemented in SignFunction by implementing the following method:
> {code}
> public OrderPreserving preservesOrder() {
> return OrderPreserving.YES;
> }
> {code}
> This will allow certain optimizations reducing the amount of memory and/or
> buffering that is required if SIGN is used in a GROUP BY or ORDER BY clause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
