[ 
https://issues.apache.org/jira/browse/PHOENIX-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598535#comment-14598535
 ] 

Siddhi Mehta commented on PHOENIX-2036:
---------------------------------------

[~giacomotaylor] , [~maghamravi] Not sure if this will work for the 
PhoenixHBaseStorage usecase

We need the case sensitive table name for the upsert statements.(e.g UPSERT 
into CUSTOM_ENTITY."z02" VALUES ...)
With the patch the OUTPUT_TABLE_NAME is case sensitive but not enclosed in 
quotes ( CUSTOM_ENTITY.z02)

We will correctly generate the columnMetadataList by passing in the case 
sensitive not enclosed in quotes table name
but  the upsert statement generated will be incorrect. (e.g  UPSERT into 
CUSTOM_ENTITY.z02 VALUES ...)

{code}
public static String getUpsertStatement(final Configuration configuration) 
throws SQLException {
       ...
            upsertStmt = QueryUtil.constructUpsertStatement(tableName, 
columnMetadataList);
        return upsertStmt;
    }
{code}

Either we need to make QueryUtil.constructUpsertStatement be aware of this 
change or push down the change  to 
org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getUpsertColumnMetadataList(Configuration)





> PhoenixConfigurationUtil should provide a pre-normalize table name to 
> PhoenixRuntime
> ------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2036
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Siddhi Mehta
>            Priority: Minor
>         Attachments: PHOENIX-2036-v1.patch, PHOENIX-2036.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I was trying a basic store using PhoenixHBaseStorage and ran into some issues 
> with it complaining about TableNotFoundException.
> The table(CUSTOM_ENTITY."z02") in question exists.
> Looking at the stacktrace I think its likely related to the change in 
> PHOENIX-1682 where phoenix runtime expects a pre-normalized table name.
> We need to update 
> PhoenixConfigurationUtil.getSelectColumnMetadataList(Configuration) be pass a 
> pre-normalized table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to