[
https://issues.apache.org/jira/browse/PHOENIX-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Levine updated PHOENIX-2058:
--------------------------------
Description:
One check I realized we're not doing, but need to do, is ensuring that the
column being added by the base table doesn't already exist in the view. If the
column does already exist, ideally we can allow the addition to the base table
if the type matches and the scale is null or >= existing scale and the
maxLength is null or >= existing maxLength. Also, if a column is a PK column
and it already exists in the view, the position in the PK must match.
The fact that we've materialized a PTable for the view should make the addition
of this check easier.
was:
One check I realized we're not doing, but need to do, is ensuring that the
column being added by the base table doesn't already exist in the view. If the
column does already exist, ideally we can allow the addition to the base table
if the type matches and the scale is null or >= existing scale and the
maxLength is null or >= existing maxLength. Also, if a column is a PK column
and it already exists in the view, the position in the PK must match. However,
since we don't allow a view to update its PK, this check isn't yet necessary
(maybe just a TODO for this).
The fact that we've materialized a PTable for the view should make the addition
of this check easier.
> Check for existence and compatibility of columns being added in view
> --------------------------------------------------------------------
>
> Key: PHOENIX-2058
> URL: https://issues.apache.org/jira/browse/PHOENIX-2058
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Samarth Jain
>
> One check I realized we're not doing, but need to do, is ensuring that the
> column being added by the base table doesn't already exist in the view. If
> the column does already exist, ideally we can allow the addition to the base
> table if the type matches and the scale is null or >= existing scale and the
> maxLength is null or >= existing maxLength. Also, if a column is a PK column
> and it already exists in the view, the position in the PK must match.
> The fact that we've materialized a PTable for the view should make the
> addition of this check easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
