[
https://issues.apache.org/jira/browse/PHOENIX-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643524#comment-14643524
]
ASF GitHub Bot commented on PHOENIX-2144:
-----------------------------------------
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/101#discussion_r35595085
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
@@ -200,12 +224,12 @@ public Expression visitLeave(ComparisonParseNode
node, List<Expression> children
Expression lhsExpr = children.get(0);
Expression rhsExpr = children.get(1);
PDataType dataTypeOfLHSExpr = lhsExpr.getDataType();
- if (dataTypeOfLHSExpr != null &&
!dataTypeOfLHSExpr.isEqualitySupported()) {
+ if (!(lhsExpr instanceof BaseJSONExpression)&& dataTypeOfLHSExpr
!= null && !dataTypeOfLHSExpr.isEqualitySupported()) {
--- End diff --
We do not support comparison (=,!=,<,>,<=,>=) of PJson data type.
PDataType.isEqualitySupported() is false for PJson, so you do not need this
check can you remove it?
> Implement JSON operators
> -------------------------
>
> Key: PHOENIX-2144
> URL: https://issues.apache.org/jira/browse/PHOENIX-2144
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Fix For: 5.0.0, 4.4.1
>
>
> See http://www.postgresql.org/docs/9.4/static/functions-json.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
