[
https://issues.apache.org/jira/browse/PHOENIX-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646563#comment-14646563
]
Samarth Jain commented on PHOENIX-2140:
---------------------------------------
Patch looks great, [~shuxi0ng].
Minor nit:
In GetSetByteBitFunctionTest and GetSetByteBitFunctionEnd2EndIT, I see that you
have the same method declared assertByteArrayEquals. You can remove that and
instead use org.apache.hadoop.hbase.util.Bytes.equals(byte[], byte[]).
Very minor nit:
Remove commented code from WhereOptimizerTest - //
assertNull(scan.getFilter()); // -> <GET_BYTE(A_BINARY, 0) = 1>
> Implement get_byte/set_byte/get_bit/set_bit Binary String build-in function
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-2140
> URL: https://issues.apache.org/jira/browse/PHOENIX-2140
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Shuxiong Ye
> Assignee: Shuxiong Ye
> Attachments:
> 0001-PHOENIX-2140-Implement-get_byte-set_byte-get_bit-set_v2.patch
>
>
> see PHOENIX-1664
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
