[jira] [Commented] (PHOENIX-2181) PhoenixHBaseLoader doesn't work with salted tables

[James Taylor (JIRA)]

    [ 
https://issues.apache.org/jira/browse/PHOENIX-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697277#comment-14697277
 ] 

James Taylor commented on PHOENIX-2181:
---------------------------------------

Thanks for the patch, [~maghamravikiran]. One small change you can fix on 
commit: the salt column is always the first column, so to skip it (in 
PhoenixRuntime.generateColumnInfo()), you can use code like this:
{code}
            int offset = (table.getBucketNum() == null ? 0 : 1);
            // use all columns in the table
            for (int i = offset; i < table.getColumns().size(); i++) {
                PColumn pColumn = table.getColumns().get(i);
                int sqlType = pColumn.getDataType().getSqlType();
                columnInfoList.add(new ColumnInfo(pColumn.toString(), 
sqlType)); 
            }
{code}

Please commit to 4.x, 4.5, and master branch.

> PhoenixHBaseLoader doesn't work with salted tables
> --------------------------------------------------
>
>                 Key: PHOENIX-2181
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2181
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: maghamravikiran
>            Assignee: maghamravikiran
>         Attachments: PHOENIX-2181.patch
>
>
> Loading data from a salted table fails in the phoenix-pig module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)