[ 
https://issues.apache.org/jira/browse/PHOENIX-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743798#comment-14743798
 ] 

Maryann Xue commented on PHOENIX-2163:
--------------------------------------

[~shuxi0ng] Just created a pull request to your repository: 
https://github.com/shuxiong/PhoenixRegressor/pull/1
Made two important changes for Phoenix+Calcite Connection, so changed the test 
driver accordingly:
1_ The Phoenix+Calcite now accepts connection strings in the same form of 
Phoenix (except that the prefix is different), and automatically adds the 
Phoenix schema as default schema.
So the test driver no longer has to treat Phoenix+Calcite differently and 
manually add Phoenix schema to the connection.

2_ Phoenix+Calcite will not add secondary index table as Calcite 
materialization if the "materialization" is disabled in the connection.
Some of the failures that occur with non-index test cases were caused by index 
table defined on salted tables (will fix that one in Calcite though), but can 
now pass with this latest change.

In addition, a few test cases used "count" as column aliases, which is not 
allowed by Calcite parser. Change them, and they should pass.

> Measure performance of Phoenix/Calcite querying
> -----------------------------------------------
>
>                 Key: PHOENIX-2163
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2163
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Shuxiong Ye
>         Attachments: PHOENIX-2163.patch, PhoenixRegressor.log, 
> calcite-test-mac.tar.gz, hbase-logs.7167262.tar.gz, publish.7167262.tar.gz
>
>
> The work to integrate Phoenix with Calcite has come along far enough that 
> queries both against the data table and through a secondary index is 
> functional. As a checkpoint, we should compare performance of as many queries 
> as possible in our regression suite for the calcite branch against the latest 
> Phoenix release (4.5.0). The runtime of these two systems should be the same, 
> so this will give us an idea of the overhead of query parsing and compilation 
> for Calcite. This is super important, as it'll identify outstanding work 
> that'll be necessary to do prior to any releases on top of this new stack.
> Source code of regression suite is at 
> https://github.com/mujtabachohan/PhoenixRegressor
> Connection string location: 
> https://github.com/mujtabachohan/PhoenixRegressor/blob/master/src/main/resources/settings.json
> Instructions on how to compile and run: 
> https://github.com/mujtabachohan/PhoenixRegressor/blob/master/README.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to