[ 
https://issues.apache.org/jira/browse/PHOENIX-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803110#comment-14803110
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-2221:
--------------------------------------------------

[~aliciashu] 
Here are some of my comments
- Add test to check index state changed to usable from readable.
- PhoenixIndexFailurePolicy#handleFailureBlockWrites have most of the duplicate 
code. I think it's same as disabling the index on failure. Please try to reuse 
the same code of disabling the index.
- do we really require INDEX_MARK_READABLE_TIMESTAMP column? Why don't we use 
INDEX_DISABLE_TIMESTAMP timestamp itself? Otherwise we need to add the column 
when upgrading from older version.
- in MetaDataClient#recoverPartialIndexFromTimeStamp why build index is 
required here? 
- I think we need to add the READABLE in proto file and compile the protocol 
files.


> Option to make data regions not writable when index regions are not available
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-2221
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2221
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Devaraj Das
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-2221.patch
>
>
> In one usecase, it was deemed better to not accept writes when the index 
> regions are unavailable for any reason (as opposed to disabling the index and 
> the queries doing bigger data-table scans).
> The idea is that the index regions are kept consistent with the data regions, 
> and when a query runs against the index regions, one can be reasonably sure 
> that the query ran with the most recent data in the data regions. When the 
> index regions are unavailable, the writes to the data table are rejected. 
> Read queries off of the index regions would have deterministic performance 
> (and on the other hand if the index is disabled, then the read queries would 
> have to go to the data regions until the indexes are rebuilt, and the queries 
> would suffer).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to