[ 
https://issues.apache.org/jira/browse/PHOENIX-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907717#comment-14907717
 ] 

Thomas D'Silva commented on PHOENIX-2286:
-----------------------------------------

[~jamestaylor]

+1 patch looks good.

Minor nit: In StatementContext looks like we don't need the transaction anymore:
{code}
    public Transaction getTransaction() {
        return transaction;
    }

    public void setTransaction(Transaction transaction) {
        this.transaction = transaction;
    }
{code}

> Checkpoint transaction when necessary
> -------------------------------------
>
>                 Key: PHOENIX-2286
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2286
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-2286_v1.patch, PHOENIX-2286_v2.patch, 
> PHOENIX-2286_wip.patch, PHOENIX-2286_wip2.patch
>
>
> To handle a statement that reads from the same table being updated, we need 
> to checkpoint the transaction and adjust the visibility so that it doesn't 
> see the data being written. Otherwise, we can get into an infinite loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to