[ 
https://issues.apache.org/jira/browse/PHOENIX-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954152#comment-14954152
 ] 

Alicia Ying Shu commented on PHOENIX-2221:
------------------------------------------

> We need not change this code any way if we don't configure anything setting 
> PhoenixIndexFailurePolicy as default.
We need the above changes that INDEX_FAILURE_POLICY_CONF_KEY is used in 
getFailurePolicy() of IndexWriter. If we did not set it, it would always be 
default policy. Readable index failure tests will fail.

>In ReadableIndexFailurePolicy we need not check for the failure policy because 
>it's any way ReadableIndexFailurePolicy so directly pass readable state bytes 
>without any checks.
The checks in ReadableIndexFailurePolicy are redundant. We can remove those. 

> Option to make data regions not writable when index regions are not available
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-2221
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2221
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Devaraj Das
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-2221-v1.patch, PHOENIX-2221-v2.patch, 
> PHOENIX-2221.patch
>
>
> In one usecase, it was deemed better to not accept writes when the index 
> regions are unavailable for any reason (as opposed to disabling the index and 
> the queries doing bigger data-table scans).
> The idea is that the index regions are kept consistent with the data regions, 
> and when a query runs against the index regions, one can be reasonably sure 
> that the query ran with the most recent data in the data regions. When the 
> index regions are unavailable, the writes to the data table are rejected. 
> Read queries off of the index regions would have deterministic performance 
> (and on the other hand if the index is disabled, then the read queries would 
> have to go to the data regions until the indexes are rebuilt, and the queries 
> would suffer).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to