[
https://issues.apache.org/jira/browse/PHOENIX-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997276#comment-14997276
]
Hudson commented on PHOENIX-2389:
---------------------------------
FAILURE: Integrated in Phoenix-master #943 (See
[https://builds.apache.org/job/Phoenix-master/943/])
PHOENIX-2389 Adding/dropping multiple columns to table in one DDL (jtaylor: rev
e1e434416f157add679f33637138e4374f067d63)
* phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java
> Adding/dropping multiple columns to table in one DDL statement is broken
> ------------------------------------------------------------------------
>
> Key: PHOENIX-2389
> URL: https://issues.apache.org/jira/browse/PHOENIX-2389
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2389.patch
>
>
> Adding multiple PK columns to a table with an index does not calculate the
> new column count correct. Here's a test:
> {code}
> @Test
> public void testAddMultipleColumns() throws Exception {
> Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
> String ddl = "CREATE TABLE T (\n"
> +"ID VARCHAR(15) PRIMARY KEY,\n"
> +"COL1 BIGINT)";
> Connection conn1 = DriverManager.getConnection(getUrl(), props);
> conn1.createStatement().execute(ddl);
> conn1.createStatement().execute("CREATE INDEX I ON T(COL1)");
>
> ddl = "ALTER TABLE T ADD COL2 VARCHAR PRIMARY KEY, COL3 VARCHAR
> PRIMARY KEY";
> conn1.createStatement().execute(ddl);
> ResultSet rs = conn1.getMetaData().getColumns("", "", "T", null);
> assertTrue(rs.next());
> assertEquals("ID",rs.getString(4));
> assertTrue(rs.next());
> assertEquals("COL1",rs.getString(4));
> assertTrue(rs.next());
> assertEquals("COL2",rs.getString(4));
> assertTrue(rs.next());
> assertEquals("COL3",rs.getString(4));
> assertFalse(rs.next());
>
> rs = conn1.createStatement().executeQuery("SELECT COLUMN_COUNT FROM
> SYSTEM.CATALOG\n"
> + "WHERE TENANT_ID IS NULL AND\n"
> + "TABLE_SCHEM IS NULL AND TABLE_NAME = 'T' AND\n"
> + "COLUMN_FAMILY IS NULL AND COLUMN_NAME IS NULL");
> assertTrue(rs.next());
> assertEquals(4,rs.getInt(1));
> assertFalse(rs.next());
> rs = conn1.createStatement().executeQuery("SELECT COLUMN_COUNT FROM
> SYSTEM.CATALOG\n"
> + "WHERE TENANT_ID IS NULL AND\n"
> + "TABLE_SCHEM IS NULL AND TABLE_NAME = 'I' AND\n"
> + "COLUMN_FAMILY IS NULL AND COLUMN_NAME IS NULL");
> assertTrue(rs.next());
> assertEquals(4,rs.getInt(1));
> assertFalse(rs.next());
>
> conn1.createStatement().execute("UPSERT INTO T VALUES
> ('a',2,'a','b')");
> conn1.createStatement().execute("UPSERT INTO T VALUES
> ('b',3,'b','c')");
> conn1.createStatement().execute("UPSERT INTO T VALUES
> ('c',4,'c','c')");
> conn1.commit();
>
> rs = conn1.createStatement().executeQuery("SELECT ID,COL1 FROM T
> WHERE COL1=3");
> assertTrue(rs.next());
> assertEquals("b",rs.getString(1));
> assertEquals(3,rs.getLong(2));
> assertFalse(rs.next());
>
> conn1.close();
> }
> {code}
> Related to this, dropping multiple columns doesn't update the column count
> correctly. Here's a test:
> {code}
> @Test
> public void testDropMultipleColumns() throws Exception {
> Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
> String ddl = "CREATE TABLE T (\n"
> + "ID VARCHAR(15) PRIMARY KEY,\n"
> + "COL1 BIGINT,"
> + "COL2 BIGINT,"
> + "COL3 BIGINT,"
> + "COL4 BIGINT)";
> Connection conn1 = DriverManager.getConnection(getUrl(), props);
> conn1.createStatement().execute(ddl);
> conn1.createStatement().execute("CREATE INDEX I ON T(COL1) INCLUDE
> (COL2,COL3,COL4)");
>
> ddl = "ALTER TABLE T DROP COLUMN COL2, COL3";
> conn1.createStatement().execute(ddl);
> ResultSet rs = conn1.getMetaData().getColumns("", "", "T", null);
> assertTrue(rs.next());
> assertEquals("ID",rs.getString(4));
> assertTrue(rs.next());
> assertEquals("COL1",rs.getString(4));
> assertTrue(rs.next());
> assertEquals("COL4",rs.getString(4));
> assertFalse(rs.next());
>
> rs = conn1.createStatement().executeQuery("SELECT COLUMN_COUNT FROM
> SYSTEM.CATALOG\n"
> + "WHERE TENANT_ID IS NULL AND\n"
> + "TABLE_SCHEM IS NULL AND TABLE_NAME = 'T' AND\n"
> + "COLUMN_FAMILY IS NULL AND COLUMN_NAME IS NULL");
> assertTrue(rs.next());
> assertEquals(3,rs.getInt(1));
> assertFalse(rs.next());
> rs = conn1.createStatement().executeQuery("SELECT COLUMN_COUNT FROM
> SYSTEM.CATALOG\n"
> + "WHERE TENANT_ID IS NULL AND\n"
> + "TABLE_SCHEM IS NULL AND TABLE_NAME = 'I' AND\n"
> + "COLUMN_FAMILY IS NULL AND COLUMN_NAME IS NULL");
> assertTrue(rs.next());
> assertEquals(3,rs.getInt(1));
> assertFalse(rs.next());
>
> conn1.createStatement().execute("UPSERT INTO T VALUES ('a',2, 20)");
> conn1.createStatement().execute("UPSERT INTO T VALUES ('b',3, 30)");
> conn1.createStatement().execute("UPSERT INTO T VALUES ('c',4, 40)");
> conn1.commit();
>
> rs = conn1.createStatement().executeQuery("SELECT ID,COL1,COL4 FROM T
> WHERE COL1=3");
> assertTrue(rs.next());
> assertEquals("b",rs.getString(1));
> assertEquals(3,rs.getLong(2));
> assertEquals(30,rs.getLong(3));
> assertFalse(rs.next());
>
> conn1.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
