Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45308492
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
---
@@ -99,18 +105,38 @@
private PMetaData metaData;
private final Map<SequenceKey, SequenceInfo> sequenceMap =
Maps.newHashMap();
private final String userName;
+ private final TransactionSystemClient txSystemClient;
private KeyValueBuilder kvBuilder;
private volatile boolean initialized;
private volatile SQLException initializationException;
private final Map<String, List<HRegionLocation>> tableSplits =
Maps.newHashMap();
- public ConnectionlessQueryServicesImpl(QueryServices queryServices,
ConnectionInfo connInfo) {
- super(queryServices);
+ public ConnectionlessQueryServicesImpl(QueryServices services,
ConnectionInfo connInfo, Properties info) {
+ super(services);
userName = connInfo.getPrincipal();
metaData = newEmptyMetaData();
// Use KeyValueBuilder that builds real KeyValues, as our test
utils require this
this.kvBuilder = GenericKeyValueBuilder.INSTANCE;
+ // TOOD: copy/paste from ConnectionQueryServicesImpl
--- End diff --
Remove this TODO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
