Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/130#discussion_r45426178
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java ---
    @@ -45,19 +45,24 @@
        private final boolean localIndex;
        private final String tableDDLOptions;
        
    --- End diff --
    
    Instead of using System.currentMillis() in the table name (which will 
create a new physical table for every test), can you create a 
TestUtil.getTableName(String prefix, boolean localIndex, boolean mutable, 
boolean transactional, Integer saltBuckets) and creates a sensible table name 
like T_LOCAL_MUTABLE_UNSALTED.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to