[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014979#comment-15014979
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/130#discussion_r45426178
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java ---
    @@ -45,19 +45,24 @@
        private final boolean localIndex;
        private final String tableDDLOptions;
        
    --- End diff --
    
    Instead of using System.currentMillis() in the table name (which will 
create a new physical table for every test), can you create a 
TestUtil.getTableName(String prefix, boolean localIndex, boolean mutable, 
boolean transactional, Integer saltBuckets) and creates a sensible table name 
like T_LOCAL_MUTABLE_UNSALTED.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to