Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/133#discussion_r45677707
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java 
---
    @@ -209,13 +212,34 @@ private static boolean isEmptyKeyValue(PTable table, 
ColumnReference ref) {
                                 .getLength()) == 0);
         }
     
    +    public static List<Delete> generateDeleteIndexData(final PTable table, 
PTable index,
    +            List<Delete> dataMutations, ImmutableBytesWritable ptr, final 
KeyValueBuilder kvBuilder, PhoenixConnection connection)
    +            throws SQLException {
    +        try {
    +            IndexMaintainer maintainer = index.getIndexMaintainer(table, 
connection);
    +            List<Delete> indexMutations = 
Lists.newArrayListWithExpectedSize(dataMutations.size());
    +            for (final Mutation dataMutation : dataMutations) {
    +                long ts = MetaDataUtil.getClientTimeStamp(dataMutation);
    +                ptr.set(dataMutation.getRow());
    +                Delete delete = maintainer.buildDeleteMutation(kvBuilder, 
ptr, ts);
    +                // TODO: move to TransactionUtil
    --- End diff --
    
    Not sure if the TODO is needed here. Remove on commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to