Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45681971
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
if (obj == null) return false;
if (getClass() != obj.getClass()) return false;
TableRef other = (TableRef)obj;
+ // a null alias on either side should mean a wildcard and should
not fail the equals check
--- End diff --
I don't think we are really implementing what is stated by this comment. We
should remove it.
Also, the alias needs a similar check the way it is for table.
if (!Objects.equal(alias, other.alias)) return false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
