Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/135#discussion_r46085765
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
 ---
    @@ -80,6 +81,9 @@ public Reader 
preStoreFileReaderOpen(ObserverContext<RegionCoprocessorEnvironmen
             HRegionInfo childRegion = region.getRegionInfo();
             byte[] splitKey = null;
             if (reader == null && r != null) {
    +            
if(!p.toString().contains(QueryConstants.LOCAL_INDEX_COLUMN_FAMILY_PREFIX)) {
    +                return super.preStoreFileReaderOpen(ctx, fs, p, in, size, 
cacheConf, r, reader);
    +            }
    --- End diff --
    
    Does the usage of this IndexHalfStoreFileReader go through limited private 
HBase APIs or are we still using private APIs here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to