Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096704
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte[][] values, int[]
pkSlotIndex, int[] columnIn
}
}
ImmutableBytesPtr ptr = new ImmutableBytesPtr();
- table.newKey(ptr, pkValues);
+ if(table.getIndexType()==IndexType.LOCAL) {
--- End diff --
I don't think we should support updating index tables directly, so I don't
think we should include this code. We've talked about having a kind of
"scrutiny" process that scans the data table and ensures that all the
corresponding indexes have the correct rows (I filed PHOENIX-2460 for this). I
suspect this would be done through our coprocessers, though, not through this
client API. WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
